fix: 🐛 apply relation functions on count queries #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Sep 10, 2023
| @@ -923,6 +923,17 @@ func (q *SelectQuery) Count(ctx context.Context) (int, error) { | |||
| return 0, q.err | |||
| } | |||
|
|
|||
| if err := q.forEachInlineRelJoin(func(j *relationJoin) error { | |||
| j.applyTo(q) | |||
There was a problem hiding this comment.
It looks like this function modifies the q. Meaning that it will be applied twice when run with ScanAndCount:
- first it will be applied by Scan
- second it will be applied by Count
If that is true, then the query generation becomes racy and unsafe....
There was a problem hiding this comment.
ScanAndCount calls the unexported count function that corresponds to Count on the main branch. If I remember correctly the lines you mention do in fact modify q but they are only run when Count (not count) is called directly.
I made this PR a while ago so I might be missing something, you tell me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #597