Support multiple manifest into one single file #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest adds support for multiple Updatecli manifest into one YAML file.
Combined with the templating engine, this open the door to very advanced scenario but this also means complex manifest without jsonschema validation...
ps: worth mentioning by default if no pipelineid are defined, then they all share the same one
Fix #961
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
This feature allows to leverage the Golang templating with things like
range
such as in the following exampleSimple manifest
values.yaml
updatecli.yaml
which shows
output
Potential improvement
While looking into this I spotted the following improvement which would be useful:
toYaml
from the sprig library feat: add yaml to/from functions Masterminds/sprig#360. I am considering adding the same function than the one used in helm as it will be exactly the same one that should be in the sprig library. This function would be the missing component to fix Feature Request: multiple/reusable configuration files #961updatecli manifest upgrade
don't work with multiple manifest into the same file. I am not considering add the support in this pullrequest because I think this command should be rework anyway.