-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async support #86
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution! 关于async请求,有以下几点建议:
|
* Test Asyncio by orig * Test Asyncio by orig * fix travis.xml error * fix async auth error * fix async parse error * fix async parse error * fix async parse error * dianose async parse error * dianose async parse error * diagnose async parse error * diagnose async parse error * diagnose async parse error * diagnose async parse error * diagnose async parse error * diagnose async parse error * diagnose async parse error * diagnose async parse error
|
httpx暂不支持proxy. |
demo测试看起来没有太大的问题。 不过有个疑问:pypi支持不同版本依赖控制吗?httpx貌似只能在python 3.6以上使用(pypi苦手 |
不支持。如果有py3的限制,那可能还是以独立库的方式来维护比较好。
另外,建议rebase你的34次修改 |
了解~ |
Closed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following changes:
(Most functions have the same functionality as the original function.)
The current test on TravisCI shows no serious problems but sometimes throws a timeout exception.
超时大概是由于请求太密集造成的?
刚准备pull的时候发现Proxy好像忘了弄QwQ
有一些修正是PyCharm自动完成的,如果出现问题可以revert掉
TravisCI: https://travis-ci.org/Mikubill/pixivpy/builds/583175481