Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content-type dependency #211

Merged
merged 4 commits into from Dec 14, 2023
Merged

Remove content-type dependency #211

merged 4 commits into from Dec 14, 2023

Conversation

samhh
Copy link
Contributor

@samhh samhh commented Dec 8, 2023

Our size-limit action is broken, but I see this locally:

$ git switch master
$ yarn install
$ yarn run build
$ yarn run size
 dist/unsplash-js.cjs.production.min.js
  Size limit: 5 KB
  Size:       4.21 KB with all dependencies, minified and gzipped

 dist/unsplash-js.esm.js
  Size limit: 5 KB
  Size:       4.22 KB with all dependencies, minified and gzipped

$ git switch content-type
$ yarn install
$ yarn run build
$ yarn run size
 dist/unsplash-js.cjs.production.min.js
  Size limit: 5 KB
  Size:       3.51 KB with all dependencies, minified and gzipped

 dist/unsplash-js.esm.js
  Size limit: 5 KB
  Size:       3.54 KB with all dependencies, minified and gzipped

It doesn't understand TypeScript overloads.
The content-type lib is unnecessary CJS bloat.
@samhh samhh marked this pull request as ready for review December 8, 2023 10:56
@samhh samhh requested a review from a team as a code owner December 8, 2023 10:56
@samhh samhh requested a review from alexcaza December 8, 2023 10:56
@samhh samhh merged commit 93e8d35 into master Dec 14, 2023
9 checks passed
@samhh samhh deleted the rm-content-type branch December 14, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants