Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editorial order by value #204

Merged
merged 1 commit into from May 10, 2023
Merged

Add editorial order by value #204

merged 1 commit into from May 10, 2023

Conversation

Magellol
Copy link
Member

@Magellol Magellol commented May 10, 2023 •
edited

It is now supported.

@Magellol Magellol marked this pull request as ready for review May 10, 2023 14:25
@Magellol Magellol requested a review from a team as a code owner May 10, 2023 14:25
@Magellol Magellol requested a review from astlouisf May 10, 2023 14:25
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited

size-limit report 📦

Path Size
dist/unsplash-js.cjs.production.min.js 4.21 KB (0%)
dist/unsplash-js.esm.js 4.22 KB (0%)

astlouisf
astlouisf approved these changes May 10, 2023
View reviewed changes
Copy link

@astlouisf astlouisf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why it is a sort order and not a filter but 🤷‍♂️

  • filter: editorial sort by: latest
  • filter: editorial sort by: relevant

seems both more useful that sort by: editorial

@Magellol
Copy link
Member Author

I think an argument can be made for both. A little bit more details here https://linear.app/unsplash/issue/UNS-1917/%F0%9F%97%82-improve-search-filters#comment-0b9035fb but I'm not sure this matters too much in this case.

@Magellol Magellol merged commit 20ab4c6 into master May 10, 2023
9 checks passed
@Magellol Magellol deleted the add-editorial branch May 10, 2023 17:31
@cameronwc cameronwc mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astlouisf astlouisf astlouisf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Magellol @astlouisf