Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Elements - fix crash, add Shadow DOM option #257

Merged
merged 2 commits into from
Jan 3, 2023

Commits on Dec 30, 2022

  1. Custom Elements: fix constructor append crash and add support for Sha…

    …dow DOM
    
    The current Web Components compiler produces an invalid Custom Element. When instantiated via `document.createElement('icon-a-b')`, it will throw an error: "Failed to construct 'CustomElement': The result must not have children".  The recommended solution from the CE spec is to append light DOM children in `connectedCallback`, so I've made that change here. I've also added a `shadow` option to have the generated CE use an open Shadow Root instead of light DOM children.
    developit committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    d7bc69c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. chore: types

    antfu committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    bd14b74 View commit details
    Browse the repository at this point in the history