perf: Enable CA1805 analyzer and fix violations

[Youssef1313]

Analyzer documentation.

GitHub Issue (If applicable): part of #6882

PR Type

What kind of change does this PR introduce?

• Performance
• Build or CI related changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

• Docs have been added/updated which fit documentation template (for bug fixes / features)
• Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
• Validated PR Screenshots Compare Test Run results.
• Contains NO breaking changes
• Associated with an issue (GitHub or internal) and uses the automatic close keywords.
• Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

[gitpod-io]

[Youssef1313]

@jeromelaban Is is more manageable to review or do you want to break it more smaller?

[Youssef1313]

Build failure is likely due to increased build time with the addition of analyzers. I'll see if I can track down if there is a specific analyzer causing that.

[jeromelaban]

It may be caused by the analyzers, but yesterday's builds were particularly slow so it may be unrelated.

[Youssef1313]

@jeromelaban

Security analyzers are a bit slow because they do heavy data-flow analysis, and CA1041 is a bit slow too dotnet/roslyn-analyzers#6143

I'll disable security analyzers and keep CA1041 enabled. If it remains slow, I'll disable CA1041 too.