Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TypeORM seems to have some issues with the latest TS release. The workaround is trivial, however, so there's no reason to hold up the TS upgrade just for rover.
The fix is to set
"skipLibCheck": true
intsconfig
. This makes it so thattsc
won't typecheck absolutely every declaration in imported libraries, just the ones that touch our code. Since the error occurs in a type definition that we don't (and won't) use, the problem is neatly resolved.Issues
Refs #4640
typeorm/typeorm#3194
Checklist: