Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable skipLibCheck in rover #4689

Merged
merged 1 commit into from Sep 4, 2019
Merged

Enable skipLibCheck in rover #4689

merged 1 commit into from Sep 4, 2019

Conversation

cnasc
Copy link
Contributor

@cnasc cnasc commented Sep 4, 2019

Description

TypeORM seems to have some issues with the latest TS release. The workaround is trivial, however, so there's no reason to hold up the TS upgrade just for rover.

The fix is to set "skipLibCheck": true in tsconfig. This makes it so that tsc won't typecheck absolutely every declaration in imported libraries, just the ones that touch our code. Since the error occurs in a type definition that we don't (and won't) use, the problem is neatly resolved.

Issues

Refs #4640
typeorm/typeorm#3194

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
    • This PR only contains configuration changes (package.json, etc.)
    • This PR only contains code changes (if configuration changes are required, do a separate PR first, then re-base)
  • My code follows the style guidelines of this project, including naming conventions
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • If my code adds or changes components, I have written corresponding stories with Storybook
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@cnasc cnasc requested review from julien51 and akeem September 4, 2019 18:47
@cla-bot cla-bot bot added the cla-signed label Sep 4, 2019
Copy link
Contributor

@akeem akeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@cnasc cnasc merged commit 19b9670 into master Sep 4, 2019
@cnasc cnasc deleted the chris-rover-ts branch September 4, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants