-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add counties #21
base: counties
Are you sure you want to change the base?
Add counties #21
Conversation
@owenam I was quite hesitant to add counties when previously proposed, but this looks really, really great. Based on a quick look, I think the API makes a lot of sense. Give me a couple days to play around with it and see if I have any feedback. Ping me if you don't hear anything by the end of the week 🙂 Thanks! |
I was on the fence as well, since its quite a bit more data! But this felt like a better alternative than repeatedly hitting the SF1 API just to get county codes, or repeatedly fetching and reading the TIGER shapefiles. The part I feel the least certain about is probably the handling of the state<->county linking in |
@jcarbaugh just checking in — what are your thoughts on this? |
This feature would be great. A few comments and questions. Counties/Parishes/Boroughs change more often than states. And Virginia FIPS codes... How does this stay up to date? Should there be point-in-time lookup? How to define Should counties.lookup support In There are going to be a lot of corner cases with fuzzy matching. How robustly should those be supported? Will jellyfish.metaphone match "St Francis, AR" with "St. Francis, AR"? Hyphenation may also be a sticking point. To reiterate, this is a great feature and I'll be happy to help with any of the above. |
County support would be fantastic. Anything an "outsider" can do to help move this along? |
+1 |
Hi, any chance to include this? I'm up for fixing whatever needs more work in this pull request. |
This adds name and FIPS data for US counties (and county equivalents like parishes), and associates them with the appropriate states. County data is pulled from the Census' 2010 TIGER data, http://www2.census.gov/geo/tiger/TIGER2010/COUNTY/2010/tl_2010_us_county10.zip.
My motivation was to have this data available to support "within county" calls to the Census API for smaller geographies like tracts and block groups. I expect that the most common use case will be to get the list of county FIPS codes for all counties in a given state.
County data is linked to states and can be accessed in a few different ways:
Note that all county lookups return a list.
I've left in some bits that might not be necessary, such as the code in
load_county_data.py
andcounty_schema.sql
for loading the county data into sqlite.Finally there may be better ways to handle the lookups and linking to states, I'm happy to discuss!