Skip to content

config/default: handle time.Duration #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2023
Merged

config/default: handle time.Duration #182

merged 3 commits into from
Feb 7, 2023

Conversation

vtolstov
Copy link
Member

@vtolstov vtolstov commented Feb 7, 2023

Signed-off-by: Vasiliy Tolstov v.tolstov@unistack.org

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
github-actions[bot]
github-actions bot previously approved these changes Feb 7, 2023
@vtolstov vtolstov enabled auto-merge February 7, 2023 03:48
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
github-actions[bot]
github-actions bot previously approved these changes Feb 7, 2023
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #182 (8159b9d) into v3 (84024f7) will decrease coverage by 0.10%.
The diff coverage is 55.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #182      +/-   ##
==========================================
- Coverage   40.73%   40.63%   -0.10%     
==========================================
  Files          97       98       +1     
  Lines        9209     9252      +43     
==========================================
+ Hits         3751     3760       +9     
- Misses       5120     5151      +31     
- Partials      338      341       +3     
Impacted Files Coverage Δ
util/time/duration.go 0.00% <0.00%> (ø)
config/default.go 24.78% <36.84%> (+2.05%) ⬆️
logger/unwrap/unwrap.go 49.77% <66.42%> (+1.72%) ⬆️
broker/memory.go 51.52% <0.00%> (-3.94%) ⬇️
network/transport/memory.go 70.55% <0.00%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d223...8159b9d. Read the comment docs.

@vtolstov vtolstov merged commit 7c29afb into v3 Feb 7, 2023
@vtolstov vtolstov deleted the timeDuration branch February 7, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant