Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invoice for @wooorm #55

Merged
merged 1 commit into from May 3, 2022
Merged

Add invoice for @wooorm #55

merged 1 commit into from May 3, 2022

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented May 2, 2022

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Hey folks! Most of my work was behind the scenes, again. This is also my last invoice in ±6 months. I’ll remain active but need to focus most time off for one particular unified project.

Some highlights of what I did this month:

I also spent time reverse engineering how GH processes the HTML after their markdown parser. Much of unified focuses on matching GitHub, but where GFM begins, what GitHub does is, is all vague, and reverse engineering is hard. Recently I made create-gfm-fixtures to help with that, which uncovered some of the tasks that GitHub performs in its pipeline: notranslate on code and pre (in comments), color chips (in comments), mentions (in comments), references (in comments), headings self-links (in files), syntax highlighting, add dir=auto to a some flow elements, gemoji to <g-emoji>, nofollow on <a>, style and '_blank' on img, but also an image CDN called camo, and a bunch of other random markup changes.
I am pretty far, but I’m waiting on some work to happen in Shiki so that syntax highlighting can match GH too, so this whole project is not yet ready to be released. I’m also not yet sure how most of this should be released. Presets? Plugins? Some things will probably be turned off because folks won’t have an image CDN or emoji images hosted somewhere?
Anyway, just wanted to mention this work as it’s a lot of work that I don’t have much to show for yet.

@wooorm wooorm merged commit 03cec07 into main May 3, 2022
@wooorm wooorm deleted the invoice-2022-04-30 branch May 3, 2022 09:44
@wooorm wooorm added the 💪 phase/solved Post is done label May 3, 2022
@RichardLitt
Copy link
Member

Approved.

@wooorm wooorm mentioned this pull request Jul 31, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants