Treat emoji presentation sequences as fullwidth #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In terms of UTS 51 conformance, with this PR, this crate will give the correct widths for:
However, it may overestimate (though never underestimate) the rendered widths of: |
Jules-Bertholet
force-pushed
the
emoji-presentation
branch
6 times, most recently
from
3cc64ff
to
5525e7d
Compare
|
I've replaced the binary search with a better datastructure, and also added a section in the rustdoc documenting the full width rules. |
Manishearth
approved these changes
Mar 5, 2024
Jules-Bertholet
force-pushed
the
emoji-presentation
branch
3 times, most recently
from
7ca0bd6
to
75be2e9
Compare
Jules-Bertholet
force-pushed
the
emoji-presentation
branch
from
a3d39f4
to
4aa5fb8
Compare
|
The not-yet-released Unicode 16 adds 8 new non-emoji standardized variation sequences that affect width: https://unicode.org/alloc/Pipeline.html#variation_sequences, https://www.unicode.org/L2/L2023/23212r-quotes-svs-proposal.pdf. In time, we'll need to support those as well. |
Jules-Bertholet
force-pushed
the
emoji-presentation
branch
from
4aa5fb8
to
9bb0575
Compare
Faster and smaller!
Ensure rows don't cross cache lines, makes a small difference in the benchmarks
Jules-Bertholet
force-pushed
the
emoji-presentation
branch
from
9bb0575
to
5e8bf9b
Compare
Merged
|
This PR is bloated, I'm splitting it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UAX11 says:
Lookup is done with a 2-level trie.