Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15764 Add examples with RTL context to reports; fix other report issues #3733

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented May 19, 2024

CLDR-15764

  • This PR completes the ticket.

Add examples with RTL context (I addition to neutral context) to the date time & numbers reports where relevant. Also fix some other report issues:

  • dateTime intervals involving a difference of just minutes had a bad end date.
  • dateTime formats combining a relative day and a time should use the "atTime" variant of the combining pattern (the fix here did not actually work, filed https://unicode-org.atlassian.net/browse/CLDR-17653 for a follow-on fix).
  • the numbers reports did not show formats for negative numbers or zero, added those.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu merged commit 928a926 into unicode-org:main May 20, 2024
10 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-15764-add-bidi-relevant-examples-to-some-reports branch May 20, 2024 19:47
@pedberg-icu
Copy link
Contributor Author

@srl295 Thanks for review. All looks good in smoketest except still not using the "atTime" variant of the dateTime combining format for the relative items. I will handle that with another PR, and probably another ticket since that was not actually one of the things requested in ticket for this.

@pedberg-icu
Copy link
Contributor Author

Filed https://unicode-org.atlassian.net/browse/CLDR-17653 for the atTime issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants