Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ESLint #10

Merged
merged 8 commits into from
Jan 25, 2017
Merged

Introduce ESLint #10

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
346928a
.eslintrc generated using polyjuice
backflip Oct 25, 2016
565ea60
Adapt .eslintrc to current code base
backflip Oct 25, 2016
e80b95a
Adapt code base to new ESLint config (where the config could not be a…
backflip Oct 25, 2016
4789bd0
Add ESLint, remove JSHint and JSCS
backflip Oct 25, 2016
6191f7f
remove commented lines and add watch config to catch changes on runtime.
Dec 15, 2016
f17a9a4
ESTATICO-170: Fix JSDoc comment
orioltf Dec 15, 2016
ebf9b0a
ESLint config: Sort rules alphabetically, fix indentation
backflip Dec 16, 2016
b5f83f7
Remove JSCS and JSHint relicts, update docs
backflip Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 9 additions & 8 deletions gulp/js/lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,26 @@

/**
* @function `gulp js:lint`
* @desc Lint JavaScript files (using `JSHint`).
* @desc Lint JavaScript files (using `ESLint`).
*/

var gulp = require('gulp');

var taskName = 'js:lint',
taskConfig = {
src: [

// './gulp/**/*.js',
// './helpers/**/*.js',
// './test/**/*.js',
// '!./test/**/expected/**/*.js',
'./source/assets/js/**/*.js',
'./source/modules/**/*.js',
'./source/pages/**/*.js',
'./source/demo/modules/**/*.js',

// './source/demo/modules/!**!/!*.jsx',
'./source/demo/pages/**/*.js',
'!./source/modules/.scaffold/scaffold.js'
],
watch: [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavaflo, if the task has its own watcher, we should probably remove it as a dependency of the js task: https://github.com/unic/estatico/blob/feature/ESTATICO-170-eslint/gulp/js/default.js#L150 (and add it to build, instead).
Otherwise, every change to a JS file will trigger the linting twice when using --skipWebpackWatch. Once directly and once as a dependency of the js task.

'./source/assets/js/**/*.js',
'./source/modules/**/*.js',
'./source/pages/**/*.js',
'./source/demo/modules/**/*.js',
'./source/demo/pages/**/*.js',
'!./source/modules/.scaffold/scaffold.js'
]
Expand Down