changed authentication method to pass client id and secret through he… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader rather than passing them as query params
|
On second thought, best not to merge this in yet until I can determine whether it's actually been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://unep-wcmc.codebasehq.com/projects/labs/tickets/3
See: omniauth/omniauth-github#84, looks like the omniauth-github team fixed this back in February. I've also fixed the Github class as well to use basic authentication instead of outright passing the access key and token in the various get requests when fetching the list of projects etc.
Can still see that our key is still being passed in the query (but not the token) though