Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2383] do not canonicalize query string in sendRedirect location #1588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UNDERTOW-2383] do not canonicalize query string in sendRedirect location #1588

wants to merge 1 commit into from

Conversation

aogburn
Copy link
Contributor

@aogburn aogburn commented Apr 26, 2024

@baranowb baranowb added under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels May 6, 2024
@baranowb baranowb requested review from fl4via and baranowb May 6, 2024 06:04
baranowb
baranowb approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@baranowb baranowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAIR.

@soul2zimate
Copy link
Contributor

@fl4via Could you review this PR? This is needed by the downstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baranowb baranowb baranowb approved these changes

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
3 participants
@aogburn @soul2zimate @baranowb