Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-1889] switch to mockito #1576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Apr 8, 2024

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check labels Apr 8, 2024
@baranowb baranowb requested a review from fl4via April 8, 2024 09:17
@baranowb baranowb removed the waiting CI check Ready to be merged but waiting for CI check label Apr 11, 2024
Comment on lines +131 to +132
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense - don't add a dependency that is never used. If a subsequent change will require this dependency, the onus will be on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor
Projects
None yet
2 participants