[UNDERTOW-1758] make state field atomic in HttpServerExchange #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
bug fix
fl4via
requested changes
Mar 15, 2024
| @@ -165,7 +166,7 @@ public final class HttpServerExchange extends AbstractAttachable { | |||
|
|
|||
| // mutable state | |||
|
|
|||
| private int state = 200; | |||
| private AtomicInteger state = new AtomicInteger(200); | |||
There was a problem hiding this comment.
@burov4j Thanks for your PR!
I would like to follow the same pattern we have in XNIO. Could you instead make the field volatile and add an atomic field updater, like in this class: https://github.com/xnio/xnio/blob/3.x/api/src/main/java/org/xnio/Connection.java ?
This will have a better memory footprint than the currently proposed solution.
carterkozak
reviewed
Mar 22, 2024
| @@ -480,9 +483,9 @@ public HttpServerExchange setRequestURI(final String requestURI) { | |||
| public HttpServerExchange setRequestURI(final String requestURI, boolean containsHost) { | |||
| this.requestURI = requestURI; | |||
| if (containsHost) { | |||
| this.state |= FLAG_URI_CONTAINS_HOST; | |||
| stateUpdater.accumulateAndGet(this, FLAG_URI_CONTAINS_HOST, (state, flag) -> state | flag); | |||
There was a problem hiding this comment.
Perhaps these lambdas could be extracted to static reusable instances -- sometimes lambdas like this in hot paths aren't elided as quickly as one might wish.
There was a problem hiding this comment.
Isn't this a premature optimization?
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/UNDERTOW-1758