Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read stored json with default UTF-8 encoding #1545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schnapster
Copy link

No description provided.

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Apr 3, 2024
@baranowb
Copy link
Contributor

baranowb commented Apr 3, 2024

@schnapster - could you please create a ticket for this PR? Also, what about UTF-16/32 This change will lock it to UTF-8 which is fine for most. Would be great to have defalt and ability to configure.

@schnapster
Copy link
Author

schnapster commented Apr 3, 2024

@baranowb for UTF-16/32, the user can simply provide a charset in the header. have a look a few lines above the code I added, it always respects the charset parameter from the header first before deciding for defaults for specific content-types.

As for the ticket - I'm not that deeply involved with the project and its details. To avoid back-and-forthing through a bespoke bureaucracy process and guidelines, please feel free to do all the required steps on my behalf, including formatting/renaming of code if necessary. "Allow edits by maintainers" is enabled =) I'd be happy sign a CLA if necessary.

Best,
Dennis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor
Projects
None yet
2 participants