Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2230] Add priority to HandlerBuilder to override internal h… #1544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xjusko
Copy link

@xjusko xjusko commented Jan 15, 2024

…andlers with predicate language
https://issues.redhat.com/browse/UNDERTOW-2230

@xjusko
Copy link
Author

xjusko commented Mar 8, 2024

Hi @fl4via, can I get a review on this PR?

@xjusko
Copy link
Author

xjusko commented Mar 14, 2024

Hi @fl4via , could you please review my PR? Thanks.

@baranowb
Copy link
Contributor

baranowb commented Apr 3, 2024

Looks good, again, why 1 if existing impl has it set to 0

@baranowb baranowb requested review from ropalka and fl4via April 3, 2024 08:12
@baranowb baranowb added enhancement Enhances existing behaviour or code waiting peer review PRs that edit core classes might require an extra review labels Apr 3, 2024
@xjusko
Copy link
Author

xjusko commented Apr 3, 2024

As in the other PR, I probably misunderstood the issue description. Now it should be implemented as it was described in the jira issue.

@ropalka ropalka added the next release This PR will be merged before next release or has already been merged (for payload double check) label Apr 8, 2024
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing behaviour or code waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
4 participants