Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1497] add request body ready bytes attribute #1536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UNDERTOW-1497] add request body ready bytes attribute #1536

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@fl4via fl4via added the bug fix Contains bug fix(es) label Nov 29, 2023
@baranowb baranowb requested a review from fl4via April 3, 2024 08:26
@baranowb baranowb mentioned this pull request Apr 16, 2024
Open
@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting peer review PRs that edit core classes might require an extra review labels Apr 16, 2024
rhusar
rhusar suggested changes Apr 19, 2024
View reviewed changes
core/src/main/java/io/undertow/server/HttpServerExchange.java
@@ -768,6 +781,10 @@ void updateBytesSent(long bytes) {
}
}

void updateBytesRead(long bytes) {
requestBytesRead+=bytes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting.

core/src/main/java/io/undertow/attribute/BytesReadAttribute.java
@@ -0,0 +1,84 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2014 Red Hat, Inc., and individual contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't apply copyright retroactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar requested changes

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
bug fix Contains bug fix(es) enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
3 participants
@baranowb @rhusar @fl4via