WIP [UNDERTOW-2312] multibytes language in URL request to http/https are … #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
the
waiting PR update
|
I'll update this PR myself as I have a test that is ready for HTTP and now I'm trying to come up with a https one. |
fl4via
added
bug fix
|
Right now I'm working on making the test work with Http2 upgrade. It seems I solved the AJP test case, I'll let you know when I'm done, and I'll update this PR with my fixes. |
baranowb
force-pushed
the
UNDERTOW-2312
branch
from
66d95db
to
22658e6
Compare
fl4via
force-pushed
the
UNDERTOW-2312
branch
from
22658e6
to
51294b4
Compare
fl4via
added
waiting PR update
|
I have just updated the PR with my latest fixes. I can see that proxy http2 scenario is not working, and the reason for this is that the code goes through a different path when serving the request, and it ends up not invoking HttpRequestParser. It might be an issue in the tests or in the code, at this point I am not sure, and I will need to investigate further to find out. |
fl4via
changed the title
|
Sometimes tests mimic desired behavior that is expected, because setup is not attainable (it seems) |
…broken in EAP access log.
fl4via
removed
waiting PR update
fl4via
force-pushed
the
UNDERTOW-2312
branch
3 times, most recently
from
55e928e
to
d2ee06d
Compare
fl4via
added
the
next release
fl4via
changed the title
…so: make the test pass on the modes for HTTP2 upgrade and AJP Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
added
waiting PR update
fl4via
changed the title
|
the failures that are left are not reproducible on my machine. They will require an investigation in github ci itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…broken in EAP access log.
ISsue: https://issues.redhat.com/browse/UNDERTOW-2312
I need to check if there are TCs for access log. Im pushing this just for review ATM.