Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2287] Add ACL style ip-match predicate #1502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UNDERTOW-2287] Add ACL style ip-match predicate #1502

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Jul 10, 2023 •
edited

@fl4via fl4via added new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting peer review PRs that edit core classes might require an extra review waiting CI check Ready to be merged but waiting for CI check labels Jul 12, 2023
ropalka
ropalka requested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back the static class modifiers otherwise every subclass of IPMatchBase will have its own inner classes created and it will cost much more memory.

core/src/main/java/io/undertow/predicate/ip/IPMatchBase.java Outdated Show resolved Hide resolved
core/src/main/java/io/undertow/predicate/ip/IPMatchBase.java Outdated
}
}

protected class ExactIpV4PeerMatch extends PeerMatch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, static modifier got lost during the refactoring

core/src/main/java/io/undertow/predicate/ip/IPMatchBase.java Outdated Show resolved Hide resolved
core/src/main/java/io/undertow/predicate/ip/IPMatchBase.java Outdated Show resolved Hide resolved
core/src/main/java/io/undertow/predicate/ip/IPMatchBase.java Outdated Show resolved Hide resolved
@baranowb baranowb requested a review from ropalka August 3, 2023 07:04
@ropalka ropalka removed the waiting peer review PRs that edit core classes might require an extra review label Aug 3, 2023
@baranowb baranowb added enhancement Enhances existing behaviour or code waiting peer review PRs that edit core classes might require an extra review and removed waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via fl4via approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases)
Projects
None yet
Milestone
No milestone
3 participants
@baranowb @ropalka @fl4via