Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2269] Handle query string properly after UNDERTOW-2206 #1478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baranowb
Copy link
Contributor

Issue: https://issues.redhat.com/browse/UNDERTOW-2269

DispatcherForwardTestCase#testIncludesUrlInPathParameters will fail.

@fl4via fl4via added the under verification Currently being verified (running tests, reviewing) before posting a review to contributor label May 24, 2023
@uqpik
Copy link

uqpik commented Aug 21, 2023

Any news about the merge request?

@baranowb baranowb added the waiting peer review PRs that edit core classes might require an extra review label Mar 27, 2024
@baranowb baranowb added the next release This PR will be merged before next release or has already been merged (for payload double check) label Mar 27, 2024
@baranowb baranowb requested review from ropalka and fl4via March 27, 2024 09:05
@baranowb
Copy link
Contributor Author

Im still investigating DispatcherIncludeTestCase.testDisptacherServletIncludeNest

@fl4via fl4via added the waiting PR update Awaiting PR update(s) from contributor before merging label Apr 4, 2024
@fl4via
Copy link
Member

fl4via commented Apr 4, 2024

Because @baranowb found a correlation if this Jira with https://issues.redhat.com/browse/UNDERTOW-2285, he is going to clean this PR up before it is ready for review, so we will be holding this one for now, let us know when it is ready for review @baranowb

@baranowb baranowb force-pushed the UNDERTOW-2269 branch 2 times, most recently from 613d000 to fc9083d Compare April 9, 2024 05:21
@fl4via fl4via removed next release This PR will be merged before next release or has already been merged (for payload double check) waiting PR update Awaiting PR update(s) from contributor before merging labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
3 participants