[UNDERTOW-2249] Add more info to the IOException thrown by ClientConnection #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
duplicate
…ection, differentiating the upgrade states from closed ones. At HttpClientTestCase.testSslServerIdentity, enforce that the exception is either a ClosedChannelException or it is an IOException with the message for invalid closed state message. Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
changed the title
fl4via
changed the title
fl4via
removed
enhancement
|
Closing as this was not the chosen solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
, differentiating the upgrade states from closed ones. At HttpClientTestCase.testSslServerIdentity, enforce that the exception is either a ClosedChannelException or it is an IOException with the message for invalid closed state message.
Jira: https://issues.redhat.com/browse/UNDERTOW-2249
Alternative to PR #1455
Which option should be chosen is being discussed at Zulip: https://wildfly.zulipchat.com/#narrow/stream/174183-undertow/topic/Should.20ClientConnection.20request.20get.20IOException.20when.20closed.3F