[UNDERTOW-2241][UNDERTOW-2247][UNDERTOW-2248] Handle write timeout properly so no chunk errors occur #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
bug fix
fl4via
force-pushed
the
UNDERTOW-2241_2247_2248_2.2.x
branch
4 times, most recently
from
24f51ae
to
09f3d49
Compare
fl4via
added
waiting PR update
Signed-off-by: Flavia Rainone <frainone@redhat.com>
…and clear the allocated buffer to prevent NPEs when ClosedChannelExceptions and broken pipe SocketExceptions occur. Those NPEs can occur at the points where the buffer is closed and it is already null because the buffer was cleared by an inner recursive call as an attempt to deal with the exception. The broken pipe can occur when a browser tab is closed during the response writing process. Signed-off-by: Flavia Rainone <frainone@redhat.com>
…reset expireTime to -1, disabling future checks for write timeout at timeoutCommand runnable Signed-off-by: Flavia Rainone <frainone@redhat.com>
…ore closing the connection to give a chance to outer channels wrap up. At ChunkedStreamSinkConduit create the last chunk and attempt to flush before truncating writes. Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
force-pushed
the
UNDERTOW-2241_2247_2248_2.2.x
branch
from
3bd90e1
to
62b575b
Compare
|
I"m closing for now, this requires further investigation. |
|
For the same reasons I had to close #1449 I'll have to close this one and open a new PR: updating the branch with force pushing is not updating the PR. The PR does not logs that the branch has been force pushed, but if I click at the link to the branch associated with this PR, I can see the updated commits in there. Closing this unfortunately :-( |
|
(github is also not showing options for reopening the PR) |
fl4via
removed
waiting PR update
|
Duplicated by #1491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jiras:
https://issues.redhat.com/browse/UNDERTOW-2241
https://issues.redhat.com/browse/UNDERTOW-2247
https://issues.redhat.com/browse/UNDERTOW-2248
Master PR: #1449