Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2251] At Http2DataStreamSinkChannel, dot not send END_STREA… #1385

Merged
merged 1 commit into from
Apr 14, 2023
Merged

[UNDERTOW-2251] At Http2DataStreamSinkChannel, dot not send END_STREA… #1385

merged 1 commit into from
Apr 14, 2023

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Oct 11, 2022 •
edited

…M in the response if response status is 100

Signed-off-by: Flavia Rainone frainone@redhat.com

Jira: https://issues.redhat.com/browse/UNDERTOW-2251
Follows up the Jira: https://issues.redhat.com/browse/UNDERTOW-2031

For more information on the absence of a test in this commit, see https://issues.redhat.com/browse/UNDERTOW-2031?focusedCommentId=21078926&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21078926

For manually reproducing the bug and verifying the fix, check https://github.com/fl4via/undertow/tree/UNDERTOW-2031-reproducer

@fl4via fl4via added bug fix Contains bug fix(es) waiting CI check Ready to be merged but waiting for CI check next release This PR will be merged before next release or has already been merged (for payload double check) failed CI Introduced new regession(s) during CI check and removed waiting CI check Ready to be merged but waiting for CI check next release This PR will be merged before next release or has already been merged (for payload double check) labels Oct 11, 2022
@fl4via fl4via added the waiting PR update Awaiting PR update(s) from contributor before merging label Mar 25, 2023
@fl4via fl4via changed the title [UNDERTOW-2031] At Http2DataStreamSinkChannel, dot not send END_STREA… [UNDERTOW-2251] At Http2DataStreamSinkChannel, dot not send END_STREA… Mar 25, 2023
@fl4via fl4via mentioned this pull request Apr 4, 2023
Merged
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) waiting CI check Ready to be merged but waiting for CI check waiting PR update Awaiting PR update(s) from contributor before merging failed CI Introduced new regession(s) during CI check under verification Currently being verified (running tests, reviewing) before posting a review to contributor and removed waiting PR update Awaiting PR update(s) from contributor before merging failed CI Introduced new regession(s) during CI check waiting CI check Ready to be merged but waiting for CI check next release This PR will be merged before next release or has already been merged (for payload double check) labels Apr 12, 2023
@fl4via
[UNDERTOW-2251] At Http2DataStreamSinkChannel, dot not send END_STREA…
a0889d2 
…M in the response if response status is 100

Signed-off-by: Flavia Rainone <frainone@redhat.com>
@fl4via fl4via removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check labels Apr 13, 2023
@fl4via fl4via merged commit cd70602 into undertow-io:master Apr 14, 2023
25 checks passed
@fl4via fl4via deleted the UNDERTOW-2031_finalFix branch April 14, 2023 13:43
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Contains bug fix(es)
Projects
None yet
Milestone
No milestone
1 participant
@fl4via