Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNDERTOW-2017: HttpRequestConduit state is correctly maintained #1288

Merged
merged 1 commit into from Feb 6, 2022

Commits on Jan 14, 2022

  1. UNDERTOW-2017: HttpRequestConduit state is correctly maintained

    Previously, small buffers that required multiple events to write
    would not save the correct header state, resulting in NPEs
    and requests which failed to include all headers.
    
    This PR removes the duplicated state between the method body
    and HttpRequestConduit in favor of exclusively using
    HttpRequestConduit fields. This way the behavior across state
    changes is unlikely to be impacted at all.
    Hotspot isn't able to optimize field access quite as well
    as local method scoped variables, however this isn't likely
    to have an impact in practice, and it's more important to
    send all headers with every request.
    carterkozak committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3491181 View commit details
    Browse the repository at this point in the history