Fix Nullpointer [UNDERTOW-2017] #1286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the null check shouldn't be necessary, but avoids an NPE when expected data is not present. I've run into this problem as well and have pushed a reproducer and (I think) a fix to #1287. The reproducer requires modifications to the HttpRequestConduit, so it shouldn't be merged, but I think that branch makes the problem more obvious (and allows me to hit this NPE every couple runs without the fix applied). |
fl4via
added
bug fix
|
I'm closing this in favor of #1288. If the bug reappears in future releases, please let us know and we'll reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.