Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1904] remove exception flow control #1186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UNDERTOW-1904] remove exception flow control #1186

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@ropalka ropalka added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) labels Jun 25, 2021
ropalka
ropalka approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fl4via fl4via added new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) and removed next release This PR will be merged before next release or has already been merged (for payload double check) labels Jul 20, 2021
fl4via
fl4via previously requested changes Feb 1, 2023
View reviewed changes
core/src/main/java/io/undertow/server/session/Session.java Outdated
@@ -183,4 +183,10 @@ public interface Session {
* @return The new session ID
*/
String changeSessionId(final HttpServerExchange exchange, final SessionConfig config);

/**
* Return state of session. NOTE: this method does not take into account if proceess of invalidation started.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo at proceess

@fl4via fl4via added the waiting PR update Awaiting PR update(s) from contributor before merging label Mar 25, 2023
@baranowb baranowb added next release This PR will be merged before next release or has already been merged (for payload double check) waiting peer review PRs that edit core classes might require an extra review and removed waiting PR update Awaiting PR update(s) from contributor before merging labels Mar 27, 2024
@baranowb baranowb requested a review from fl4via March 27, 2024 09:02
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
3 participants
@baranowb @ropalka @fl4via