Merge pull request #1359 from fl4via/2.2.x_backport_bug_fixes

[UNDERTOW-2031][UNDERTOW-2113][UNDERTOW-2130][UNDERTOW-2133][UNDERTOW-2135] backport bug fixes to 2.2.x branch
undertow-io · Aug 11, 2022 · 5177c78 · 5177c78
2 parents 52a81e5 + 1d95f77
commit 5177c78
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 16 deletions.
diff --git a/core/src/main/java/io/undertow/server/protocol/ajp/AjpServerRequestConduit.java b/core/src/main/java/io/undertow/server/protocol/ajp/AjpServerRequestConduit.java
@@ -31,6 +31,7 @@
 import io.undertow.conduits.ConduitListener;
 import io.undertow.server.Connectors;
 import io.undertow.server.HttpServerExchange;
+import io.undertow.server.RequestTooBigException;
 import io.undertow.util.ImmediatePooledByteBuffer;
 import org.xnio.IoUtils;
 import org.xnio.channels.StreamSinkChannel;
@@ -202,6 +203,8 @@ public int read(ByteBuffer dst) throws IOException {
             }
             assert STATE_FINISHED == state;
             return -1;
+        } catch (RequestTooBigException e) {
+            throw e;
         } catch (IOException | RuntimeException e) {
             IoUtils.safeClose(exchange.getConnection());
             throw e;

diff --git a/core/src/main/java/io/undertow/server/protocol/http/HttpContinue.java b/core/src/main/java/io/undertow/server/protocol/http/HttpContinue.java
@@ -142,7 +142,6 @@ public void awaitWritable(long time, TimeUnit timeUnit) throws IOException {
         HttpServerExchange newExchange = exchange.getConnection().sendOutOfBandResponse(exchange);
         exchange.putAttachment(ALREADY_SENT, true);
         newExchange.setStatusCode(StatusCodes.CONTINUE);
-        newExchange.getResponseHeaders().put(Headers.CONTENT_LENGTH, 0);
         final StreamSinkChannel responseChannel = newExchange.getResponseChannel();
         return new ContinueResponseSender() {
             boolean shutdown = false;
@@ -219,7 +218,6 @@ private static void internalSendContinueResponse(final HttpServerExchange exchan
         HttpServerExchange newExchange = exchange.getConnection().sendOutOfBandResponse(exchange);
         exchange.putAttachment(ALREADY_SENT, true);
         newExchange.setStatusCode(StatusCodes.CONTINUE);
-        newExchange.getResponseHeaders().put(Headers.CONTENT_LENGTH, 0);
         final StreamSinkChannel responseChannel = newExchange.getResponseChannel();
         try {
             responseChannel.shutdownWrites();

diff --git a/core/src/main/java/io/undertow/server/protocol/http2/Http2UpgradeHandler.java b/core/src/main/java/io/undertow/server/protocol/http2/Http2UpgradeHandler.java
@@ -74,9 +74,8 @@ public Http2UpgradeHandler(HttpHandler next, String... upgradeStrings) {
     public void handleRequest(HttpServerExchange exchange) throws Exception {
         final String upgrade = exchange.getRequestHeaders().getFirst(Headers.UPGRADE);
         final String settings = exchange.getRequestHeaders().getFirst("HTTP2-Settings");
-        if(settings != null && upgrade != null
-                && upgradeStrings.contains(upgrade)) {
-            if(HttpContinue.requiresContinueResponse(exchange) && false) {
+        if(settings != null && upgrade != null && upgradeStrings.contains(upgrade)) {
+            if(HttpContinue.requiresContinueResponse(exchange)) {
                 HttpContinue.sendContinueResponse(exchange, new IoCallback() {
                     @Override
                     public void onComplete(HttpServerExchange exchange, Sender sender) {

diff --git a/core/src/test/java/io/undertow/server/ReadTimeoutTestCase.java b/core/src/test/java/io/undertow/server/ReadTimeoutTestCase.java
@@ -136,7 +136,7 @@ public long getContentLength() {
                 client.execute(post);
             } catch (SocketException e) {
                 Assert.assertTrue(e.getMessage(), e.getMessage().contains("Broken pipe")
-                        || e.getMessage().contains("connection abort"));
+                        || e.getMessage().contains("connection abort") || e.getMessage().contains("connection was aborted"));
                 socketFailure = true;
             }
             Assert.assertTrue("Test sent request without any exception", socketFailure);

diff --git a/servlet/src/test/java/io/undertow/servlet/test/streams/EarlyCloseClientServlet.java b/servlet/src/test/java/io/undertow/servlet/test/streams/EarlyCloseClientServlet.java
@@ -18,9 +18,6 @@
 
 package io.undertow.servlet.test.streams;
 
-import io.undertow.testutils.DefaultServer;
-import org.junit.runner.RunWith;
-
 import javax.servlet.ServletException;
 import javax.servlet.ServletInputStream;
 import javax.servlet.http.HttpServlet;
@@ -33,7 +30,6 @@
 /**
  * @author Stuart Douglas
  */
-@RunWith(DefaultServer.class)
 public class EarlyCloseClientServlet extends HttpServlet {
 
     private static volatile boolean exceptionThrown;

diff --git a/servlet/src/test/java/io/undertow/servlet/test/streams/EarlyCloseServlet.java b/servlet/src/test/java/io/undertow/servlet/test/streams/EarlyCloseServlet.java
@@ -29,12 +29,10 @@
 import io.undertow.servlet.handlers.ServletRequestContext;
 import io.undertow.servlet.spec.HttpServletRequestImpl;
 import io.undertow.testutils.DefaultServer;
-import org.junit.runner.RunWith;
 
 /**
  * @author Stuart Douglas
  */
-@RunWith(DefaultServer.class)
 public class EarlyCloseServlet extends HttpServlet {
 
     private volatile ServerConnection connection;

diff --git a/servlet/src/test/java/io/undertow/servlet/test/streams/ForceDrainServlet.java b/servlet/src/test/java/io/undertow/servlet/test/streams/ForceDrainServlet.java
@@ -23,14 +23,10 @@
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-import org.junit.runner.RunWith;
-
-import io.undertow.testutils.DefaultServer;
 
 /**
  * @author Stuart Douglas
  */
-@RunWith(DefaultServer.class)
 public class ForceDrainServlet extends HttpServlet {
 
     @Override