Skip to content

fix: sort models by deps #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2022
Merged

fix: sort models by deps #9846

merged 3 commits into from
Dec 1, 2022

Conversation

elivoa
Copy link
Contributor

@elivoa elivoa commented Nov 23, 2022

fix sorting models by deps in plugin-model.

see also: #9837

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
umi ⬜️ Ignored (Inspect) Nov 25, 2022 at 9:53AM (UTC)

@fz6m
Copy link
Contributor

fz6m commented Nov 24, 2022

写下单测吧,这个比较复杂。

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 29.21% // Head: 29.57% // Increases project coverage by +0.36% 🎉

Coverage data is based on head (cf6fff6) compared to base (1ef5cba).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9846      +/-   ##
==========================================
+ Coverage   29.21%   29.57%   +0.36%     
==========================================
  Files         429      429              
  Lines       12207    12246      +39     
  Branches     2923     2928       +5     
==========================================
+ Hits         3566     3622      +56     
+ Misses       8079     8068      -11     
+ Partials      562      556       -6     
Impacted Files Coverage Δ
packages/plugins/src/utils/modelUtils.ts 64.12% <94.11%> (+30.51%) ⬆️
packages/mfsu/src/dep/dep.ts 15.51% <0.00%> (-2.86%) ⬇️
packages/mfsu/src/moduleGraph.ts 99.28% <0.00%> (-0.72%) ⬇️
packages/mfsu/src/mfsu/strategyStaticAnalyze.ts 7.05% <0.00%> (-0.09%) ⬇️
packages/mfsu/src/depInfo.ts 10.00% <0.00%> (ø)
packages/plugins/src/layout.ts 0.00% <0.00%> (ø)
packages/plugins/src/request.ts 0.00% <0.00%> (ø)
packages/plugins/src/qiankun/slave.ts 0.00% <0.00%> (ø)
packages/preset-umi/src/commands/build.ts 0.00% <0.00%> (ø)
...kages/preset-umi/src/features/tmpFiles/tmpFiles.ts 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要用例,这个肉眼看不出正确性,不敢合啊。

@elivoa
Copy link
Contributor Author

elivoa commented Nov 24, 2022

明天我加一些test进去。

@elivoa elivoa requested a review from fz6m November 25, 2022 02:45
@elivoa
Copy link
Contributor Author

elivoa commented Nov 25, 2022

@fz6m 多谢指教,上述问题均已修复,并付上test且自测通过。已经点了申请重新审查,不知道我操作的对不对。

@fz6m
Copy link
Contributor

fz6m commented Nov 25, 2022

有多处需要变动,帮你改了下,感谢 PR 。

@elivoa
Copy link
Contributor Author

elivoa commented Nov 30, 2022

@fz6m 请问下目前这个PR的进度是怎样的?什么时候能合并并发tag?我的项目在等这个修复才能上线。

@sorrycc sorrycc merged commit 12f9b0f into umijs:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants