-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: sort models by deps #9846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sort models by deps #9846
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
写下单测吧,这个比较复杂。 |
Codecov ReportBase: 29.21% // Head: 29.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #9846 +/- ##
==========================================
+ Coverage 29.21% 29.57% +0.36%
==========================================
Files 429 429
Lines 12207 12246 +39
Branches 2923 2928 +5
==========================================
+ Hits 3566 3622 +56
+ Misses 8079 8068 -11
+ Partials 562 556 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要用例,这个肉眼看不出正确性,不敢合啊。
明天我加一些test进去。 |
@fz6m 多谢指教,上述问题均已修复,并付上test且自测通过。已经点了申请重新审查,不知道我操作的对不对。 |
有多处需要变动,帮你改了下,感谢 PR 。 |
@fz6m 请问下目前这个PR的进度是怎样的?什么时候能合并并发tag?我的项目在等这个修复才能上线。 |
fix sorting models by deps in plugin-model.
see also: #9837