-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix/mfsu relative entry #9800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/mfsu relative entry #9800
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportBase: 29.47% // Head: 30.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #9800 +/- ##
==========================================
+ Coverage 29.47% 30.26% +0.78%
==========================================
Files 429 429
Lines 12251 12260 +9
Branches 2934 2934
==========================================
+ Hits 3611 3710 +99
+ Misses 8080 7993 -87
+ Partials 560 557 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
basedir 不一致的问题可以用固定的 context 解。 |
0eff04f
to
2099c91
Compare
修理一下 ci |
2005eff
to
97e5911
Compare
修复好了 |
@mysteryven 如果能再加个 e2e 测试就更完美了 [暗中观察] ref: https://github.com/umijs/umi/blob/master/.github/workflows/e2e-mfsu.yml |
e6c2015
to
8f9bc56
Compare
已经加好了呢,修改点如下:
PS: 昨天我的电脑更新了 pnpm (7.17.0)版本,和 CI 使用的版本不同,导致两者生成的 lock 文件格式和不一致,所以一直提示失败。下面对 pnpm 的 7.3.0 和 7.17.0 进行 diff: # filename: pnpmlock.yaml
packages/renderer-vue:
specifiers:
'@babel/runtime': 7.18.9
+ vue: '>=3.2.31'
+ vue-router: '>=4.0.12'
dependencies:
'@babel/runtime': 7.18.9
+ vue: 3.2.36
+ vue-router: 4.0.15_vue@3.2.36
filename: packages/renderer-vue/package.json "dependencies": {
"@babel/runtime": "7.18.9"
},
"peerDependencies": {
"vue": ">=3.2.31",
"vue-router": ">=4.0.12"
}, 解决方案:
|
8f9bc56
to
4245c25
Compare
pnpm-lock.yaml 冲突了,需要 merge master 解下冲突。 |
4245c25
to
0625c76
Compare
pnpm 版本问题可以再提一个 PR ,改下 package.json#packageManager ,刷下 lock 文件,我们都用最新版本就行。 |
0625c76
to
e65b0fb
Compare
已解决 ~ |
抱歉,又冲突了,需要再 merge 下 master。 |
e65b0fb
to
3337f99
Compare
test(mfsu): init e2e test * chore(mfsu): update lock file
3337f99
to
899aa04
Compare
已经解决了,但是今天的 CI 好像有点慢。 |
fix: #9799
改动点:
不确定点:
测试用例用到的文件放在了
packages/mfsu/fixtures
,但是这样只能在packages/mfsu/
而不能在根目录运行测试用例:为了兼容在项目根目录和 mfsu 目录运行测试用例,更改为:
不确定有没有其他好的方法,临时创建文件会不会更好一点。