Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SSR not supports node 14.x optional chaining #4980

Merged
merged 5 commits into from Jul 7, 2020
Merged

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Jul 6, 2020

ref: webpack/webpack#10227
Close #4873

image

修复 SSR 不支持 Node 14 默认开启的 Optional Chaining

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #4980 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4980   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files         153      153           
  Lines        3372     3372           
  Branches      883      897   +14     
=======================================
  Hits         2800     2800           
+ Misses        565      564    -1     
- Partials        7        8    +1     
Impacted Files Coverage Δ
packages/babel-preset-umi/src/index.ts 85.71% <ø> (ø)
packages/core/src/Config/Config.ts 61.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683594c...076a093. Read the comment docs.

@ycjcl868 ycjcl868 requested a review from sorrycc July 6, 2020 12:22
@ycjcl868 ycjcl868 changed the title chore: ci with node 14.x fix: SSR supports node 14.x Jul 6, 2020
@ycjcl868 ycjcl868 changed the title fix: SSR supports node 14.x fix: SSR not supports node 14.x optional chaining Jul 6, 2020
@sorrycc sorrycc merged commit bcb4daa into master Jul 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore-node-14 branch July 7, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants