Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade typescript to ~5.3.3 #738

Merged
merged 2 commits into from Jan 26, 2024
Merged

Conversation

bestlyg
Copy link
Contributor

@bestlyg bestlyg commented Jan 19, 2024

参考 #682 升级typescript和@microsoft/api-extractor的版本。

在项目中使用father bulid报错,使用tsc构建正常。
Demo:

export function styleMap(cssStyleRule: CSSStyleRule) {
  return cssStyleRule.styleMap;
}

目前father中依赖的ts仅支持5.0.X,此时CSSStyleRule类型上并没有styleMap,在ts后续版本中已经更新了类型定义。
期望升级father依赖的ts版本,使构建不报错。

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f950ce) 94.45% compared to head (b5081b5) 94.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          55       55           
  Lines        1570     1570           
  Branches      358      358           
=======================================
  Hits         1483     1483           
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit 86a7516 into umijs:master Jan 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants