Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: d.ts pre emit diagnostics lost after compilation #701

Merged
merged 4 commits into from Aug 31, 2023

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Aug 29, 2023

修复 d.ts 生成时部分 TypeScript 诊断错误不会抛出的问题,原因是实现 Compiler 的时候未按照 TypeScript 文档的指示将 PreEmitDiagnostics 也合并进来处理,ref: https://github.com/microsoft/TypeScript/wiki/Using-the-Compiler-API#a-minimal-compiler

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.37% 🎉

Comparison is base (2150873) 93.81% compared to head (46612ad) 94.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   93.81%   94.19%   +0.37%     
==========================================
  Files          54       54              
  Lines        1537     1532       -5     
  Branches      365      364       -1     
==========================================
+ Hits         1442     1443       +1     
+ Misses         90       89       -1     
+ Partials        5        0       -5     
Files Changed Coverage Δ
src/builder/bundless/dts/index.ts 100.00% <100.00%> (+8.10%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeachScript PeachScript merged commit 6388306 into master Aug 31, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the hotfix/d-ts-error-lost branch August 31, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants