Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pre-bundle for legacy built-in-modules #671

Merged
merged 1 commit into from Jul 20, 2023

Conversation

nanianlisao
Copy link
Contributor

支持对 urlutil 等跟 builtin-module 同名的库进行预编译。

之前会报错,因为 require.resolve('url') 返回的 entryurl, 传递给ncc会报错。

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (8df2e42) 93.79% compared to head (573d0b5) 93.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.01%     
==========================================
  Files          54       54              
  Lines        1531     1535       +4     
  Branches      364      365       +1     
==========================================
+ Hits         1436     1440       +4     
+ Misses         95       90       -5     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/prebundler/config.ts 100.00% <100.00%> (ø)
src/utils.ts 98.73% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nanianlisao
Copy link
Contributor Author

@PeachScript 哈喽,能麻烦尽快跟进一下吗

@PeachScript
Copy link
Member

@PeachScript 哈喽,能麻烦尽快跟进一下吗

感谢贡献,上周没来及看,预计这周内处理

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript changed the title feat: support prebuild for builtin-module feat: support pre-bundle for legacy built-in-modules Jul 20, 2023
@PeachScript PeachScript merged commit 611f00c into umijs:master Jul 20, 2023
9 checks passed
@PeachScript
Copy link
Member

v4.3.0 已发布,包含该 PR 的变更

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants