feat: support npm alias name for prebundle #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
==========================================
+ Coverage 93.77% 93.79% +0.02%
==========================================
Files 55 54 -1
Lines 1525 1531 +6
Branches 361 364 +3
==========================================
+ Hits 1430 1436 +6
Misses 95 95
☔ View full report in Codecov by Sentry. |
PeachScript
reviewed
Jun 13, 2023
| @@ -147,7 +147,7 @@ export function getConfig(opts: { | |||
| pkg: depPkg, | |||
| output: path.resolve( | |||
| opts.cwd, | |||
| `${output || DEFAULT_OUTPUT_DIR}/${depPkg.name}/index.js`, | |||
| `${output || DEFAULT_OUTPUT_DIR}/${depName}/index.js`, | |||
There was a problem hiding this comment.
直接使用用户的配置值可能会存在 Breaking Change，目前想到这两种 case：
- 配置值可能是 NPM 包的文件路径（类似
pkg/lib/other） - 配置值可能是项目的本地文件（类似 Umi 仓库中 bundler-utils 子包的情况，虽然没有直接使用 father）
想到的解法你看看是否合适，创建 getDepPkgName(depName, depPkg) 的工具方法，有两层逻辑：
- 如果
depName不是绝对路径或.开头的相对路径，则尝试截取 depName 中包名的部分，比如pkg/lib/other=>pkg，@org/pkg/index=>@org/pkg - 反之兜底到
depPkg.name，同时需要看下 issue 里提到的minimatch获取 pkg 失败的问题，按理说getDepPkg有使用 pkgUp 处理，应该能拿到才是
|
关于 |
PeachScript
reviewed
Jun 13, 2023
PeachScript
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #662