Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle svg as normal image assets in bundle mode #607

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

PeachScript
Copy link
Member

father 禁用 svgr,所以在 bundle 模式下也将 svg 也当做普通图片资源处理,base64 or 转为独立文件

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4563346) 94.68% compared to head (b8d1683) 94.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files          51       51           
  Lines        1429     1431    +2     
  Branches      339      339           
=======================================
+ Hits         1353     1355    +2     
  Misses         76       76           
Impacted Files Coverage Δ
src/builder/bundle/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PeachScript PeachScript merged commit 428b8d7 into master Mar 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/bundle-svg branch March 16, 2023 09:09
@fz6m
Copy link
Member

fz6m commented Mar 16, 2023

有个 svgr 选项吧,改成 false 就可以走 fallback 变成静态资源了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants