fix: rule PHANTOM_DEPS support optional deps (#618)

* fix: rule PHANTOM_DEPS support optional deps * test: add optional deps case
umijs · Apr 3, 2023 · 6629edd · 6629edd
1 parent e95c969
commit 6629edd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/src/doctor/rules/PHANTOM_DEPS.ts b/src/doctor/rules/PHANTOM_DEPS.ts
@@ -17,6 +17,7 @@ export default (api: IApi) => {
         api.pkg.name !== pkgName &&
         !api.pkg.dependencies?.[pkgName] &&
         !api.pkg.peerDependencies?.[pkgName] &&
+        !api.pkg.optionalDependencies?.[pkgName] &&
         aliasKeys.every((k) => k !== i.path && !i.path.startsWith(`${k}/`)) &&
         !mergedExternals[i.path]
       ) {

diff --git a/tests/fixtures/doctor/health/package.json b/tests/fixtures/doctor/health/package.json
@@ -4,5 +4,8 @@
   ],
   "dependencies": {
     "hello.world": "0.0.0"
+  },
+  "optionalDependencies": {
+    "optional": "0.0.0"
   }
 }
diff --git a/tests/fixtures/doctor/health/src/index.ts b/tests/fixtures/doctor/health/src/index.ts
@@ -1,2 +1,3 @@
 // expect handle pkg name includes .
 import 'hello.world';
+import 'optional';