Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-cjs module may be unexpectedly resolved due to wrong conditions #2090

Merged
merged 2 commits into from Apr 28, 2024

Conversation

Jinbao1001
Copy link
Member

…p error

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English reslove conditionNames just for commonjs and supplement prod skip err
🇨🇳 Chinese resolve 条件名只针对commonjs 并增加livedemo 生产环境需要跳过处理的错误类型

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 6:17am

@PeachScript PeachScript changed the title fix: reslove conditionNames just for commonjs and supplement prod skip err fix: non-cjs module may be unexpectedly resolved due to wrong conditions Apr 28, 2024
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit 083a916 into master Apr 28, 2024
9 checks passed
@PeachScript PeachScript deleted the Jinbao/fix-05 branch April 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants