fix: active position for toc scrolling highlight #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zhou-Bill
force-pushed
the
hotfix/sidebar_active
branch
from
385ef05
to
d5afebc
Compare
Zhou-Bill
force-pushed
the
hotfix/sidebar_active
branch
from
d5afebc
to
d10d32b
Compare
Zhou-Bill
force-pushed
the
hotfix/sidebar_active
branch
from
d10d32b
to
4e3c4e3
Compare
Zhou-Bill
force-pushed
the
hotfix/sidebar_active
branch
from
4e3c4e3
to
ec9000a
Compare
PeachScript
reviewed
Apr 29, 2024
PeachScript
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
fix #2007
💡 需求背景和解决方案 / Background or solution
由于header 的布局是
sticky, 当点击左侧sidebar时，核心 API这个锚点内容还是处于可视状态，即currentElementIndexInViewport还是在当前的key中， 所以这里需要用-offset (header的高度)，触发它的激活状态📝 更新日志 / Changelog