fix(define-config): param types incorrect #1274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yimingbot
changed the title
PeachScript
reviewed
Nov 17, 2022
PeachScript
reviewed
Nov 25, 2022
src/types.ts
Outdated
| type NoStringIndex<T> = { | ||
| [K in keyof T as string extends K ? never : K]: T[K]; | ||
| }; | ||
| type IUmiConfig = NoStringIndex<Parameters<typeof defineConfig>[0]>; |
There was a problem hiding this comment.
我本地试了下好像不太行，defineConfig 的参数类型拿出来就是 any 了，不知道是不是类型系统的限制，因为是依赖的依赖
There was a problem hiding this comment.
试了下我本地也不行了，之前莫名可以。。
要不还是从preset-umi导入IConfig吧，或者让umi加个导出export type { IConfig } from '@umijs/preset-umi';
This reverts commit 37b4b10.
|
#1389 已用另一个思路修复该问题，感谢提交 PR，希望继续帮助 dumi 改进 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
#1216 (reply in thread)
💡 需求背景和解决方案 / Background or solution
从@umijs/preset-umi导入IConfig(umi没有直接导出)，然后删除[key: string]: any，避免Omit失效
📝 更新日志 / Changelog