Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnm: grpc fixes testing #1688

Closed
wants to merge 6 commits into from
Closed

dnm: grpc fixes testing #1688

wants to merge 6 commits into from

Conversation

adamewozniak
Copy link
Collaborator

Description


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

⚠️ The sha of the head commit of this PR conflicts with #1687. Mergify cannot evaluate rules on this PR. ⚠️

@codecov-commenter
Copy link

Codecov Report

Merging #1688 (5d1c910) into main (13745da) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   57.82%   57.97%   +0.15%     
==========================================
  Files          73       73              
  Lines        7589     7821     +232     
==========================================
+ Hits         4388     4534     +146     
- Misses       2858     2934      +76     
- Partials      343      353      +10     
Impacted Files Coverage Δ
x/leverage/keeper/oracle.go 62.93% <0.00%> (-0.04%) ⬇️
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/leverage/client/tests/tests.go 100.00% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 64.84% <0.00%> (+2.29%) ⬆️
x/leverage/keeper/limits.go 50.00% <0.00%> (+6.98%) ⬆️

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

⚠️ The sha of the head commit of this PR conflicts with #1687. Mergify cannot evaluate rules on this PR. ⚠️

@robert-zaremba robert-zaremba deleted the dnm/woz/grpc-test-fixes branch April 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants