Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] backoffice user login providers endpoint #16141

Merged
merged 17 commits into from
May 14, 2024

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Apr 24, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Added an endpoint to get a all available external login providers with status for the current user to show whether it is linked or not.

During tests and pair review, it was noted the methods in the backofficecontroller had to much logic, so I refactored methods that had to do with linking/unlinking into a separate service as this logic was part of the test path for setting up the new endpoint.

Added unit tests for the new service

Testing

  • You can still unlink providers as described in V14 External login linking + Proposed error handling #16052
  • Linking now requires you to 'preauthenticate' the endpoint by calling GET https://localhost:44339/umbraco/management/api/v1/security/back-office/link-login-key?provider=yourprovider and then to use the obtained key in the actual link call
  • Using the steps above, you should be able to manipulate the output of the new endpoint GET:/umbraco/management/api/v1/user/current/login-providers

@Migaroez Migaroez added the project/bellissima AKA "the new backoffice" label Apr 24, 2024
@Migaroez Migaroez requested a review from kjac April 25, 2024 10:49
@Migaroez Migaroez marked this pull request as ready for review May 7, 2024 09:08
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@Migaroez Migaroez merged commit 742307d into v14/dev May 14, 2024
14 checks passed
@Migaroez Migaroez deleted the v14/feature/backoffice-user-login-providers branch May 14, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project/bellissima AKA "the new backoffice"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants