-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14] backoffice user login providers endpoint #16141
Merged
Migaroez
merged 17 commits into
v14/dev
from
v14/feature/backoffice-user-login-providers
May 14, 2024
Merged
[v14] backoffice user login providers endpoint #16141
Migaroez
merged 17 commits into
v14/dev
from
v14/feature/backoffice-user-login-providers
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the status per user.
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
kjac
reviewed
May 6, 2024
...Umbraco.Cms.Api.Management/ViewModels/User/Current/UserExternalLoginProviderResponseModel.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 10, 2024
src/Umbraco.Cms.Api.Management/Services/BackOfficeExternalLoginService.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 10, 2024
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs
Show resolved
Hide resolved
kjac
reviewed
May 10, 2024
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs
Show resolved
Hide resolved
kjac
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Added an endpoint to get a all available external login providers with status for the current user to show whether it is linked or not.
During tests and pair review, it was noted the methods in the
backofficecontroller
had to much logic, so I refactored methods that had to do with linking/unlinking into a separate service as this logic was part of the test path for setting up the new endpoint.Added unit tests for the new service
Testing
https://localhost:44339/umbraco/management/api/v1/security/back-office/link-login-key?provider=yourprovider
and then to use the obtained key in the actual link call/umbraco/management/api/v1/user/current/login-providers