Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __Key field from Backoffice Search if query is not a Guid #16004

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

Conversation

mcl-sz
Copy link
Contributor

@mcl-sz mcl-sz commented Apr 7, 2024

When a short search query is used, irrelevant results may arise because the query appears in the Key guide.

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #16003

Description

When a short search query is used in the Backoffice Search, irrelevant results may arise because the query appears in the Key value.

Before:
afbeelding

After:

afbeelding

When a short search query is used, irrelevant results may arise because the query appears in the Key guide.
Copy link

github-actions bot commented Apr 7, 2024

Hi there @mcl-sz, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Matthew-Wise
Copy link
Contributor

Hey @mcl-sz ! Thank you for your PR to fix #16003 Someone on the core collaborators team will review this soon . Had a quick look at makes sense to me :) Just need to do some testing of course

Thanks
Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backoffice search returns irrelevant results because Key is part of the search query
2 participants