New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable testing on PyPy for all platforms. #553
Conversation
PyPy's Windows unicode handling transpired to be significantly different enough that a PyPy+Windows specific test failure slipped in (ultrajson#552).
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 6 6
Lines 1824 1825 +1
=======================================
+ Hits 1675 1676 +1
Misses 149 149
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three of the 15 parametrised cases pass and show as xpasses instead of xfails:
tests\test_ujson.py ........................sssssssssss.............................XXxxxxxxxxxxxxs.......................................................................................................................................................................................s..s
=========== 238 passed, [14](https://github.com/ultrajson/ultrajson/runs/6943256123?check_suite_focus=true#step:5:15) skipped, 12 xfailed, 2 xpassed in 7.00s ============
We could add a condition to only skip those that really do fail (and possibly add strict checking so xpasses fail), but we'll have a fix soon so this is fine. 👍
.github/workflows/test.yml
Outdated
- { python-version: "3.10", os: windows-latest } | ||
- { python-version: "3.10", os: macos-latest } | ||
- { python-version: "pypy-3.8", os: windows-latest } | ||
- { python-version: "pypy-3.8", os: macos-latest } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyPy tests are a bit slower than CPython, let's give them a bit of a headstart:
- { python-version: "3.10", os: windows-latest } | |
- { python-version: "3.10", os: macos-latest } | |
- { python-version: "pypy-3.8", os: windows-latest } | |
- { python-version: "pypy-3.8", os: macos-latest } | |
- { python-version: "pypy-3.8", os: windows-latest } | |
- { python-version: "pypy-3.8", os: macos-latest } | |
- { python-version: "3.10", os: windows-latest } | |
- { python-version: "3.10", os: macos-latest } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly certain that the order in which you declare them is ignored. I've tried reording jobs before and it didn't make any difference. That was a while ago though so it might have changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature needs fixing. See ultrajson#552.
e500f3f
to
404de1a
Compare
Oohps, pushed that last commit to the wrong branch... |
Thank you! |
Addresses (but doesn't fix) #552.