Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark CI fixes #534

Merged
merged 6 commits into from Apr 27, 2022
Merged

Benchmark CI fixes #534

merged 6 commits into from Apr 27, 2022

Conversation

Erotemic
Copy link
Contributor

Fix for issue introduced in #533

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #534 (4e527b8) into main (a900e46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files           6        6           
  Lines        1821     1821           
=======================================
  Hits         1671     1671           
  Misses        150      150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a900e46...4e527b8. Read the comment docs.

@Erotemic
Copy link
Contributor Author

Erotemic commented Apr 25, 2022

@hugovk looks like I forgot to add a default case to --disable. I fixed that and added the lines to test the benchmarks in the PR if the file itself is changed (which is really cool, I didn't know you could conditionally run workflows based on if a specific file is part of the commit).

@hugovk hugovk added the changelog: skip Exclude PR from release draft label Apr 26, 2022
tests/benchmark.py Outdated Show resolved Hide resolved
Erotemic and others added 4 commits April 26, 2022 12:30
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk changed the title CI Fixes Benchmark CI fixes Apr 27, 2022
@hugovk hugovk merged commit ebdb150 into ultrajson:main Apr 27, 2022
@hugovk
Copy link
Member

hugovk commented Apr 27, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants