Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that JSONDecodeError is an actual subclass of ValueError, not just an alias #500

Conversation

JustAnotherArchivist
Copy link
Collaborator

Follow-up for #498. Sorry, I forgot that issubclass(x, x) is True, therefore that test would pass even if JSONDecodeError were simply an alias of ValueError rather than a proper subclass. This adds a check that they are not identical.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #500 (4ffc7dd) into main (316d384) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   88.78%   88.79%           
=======================================
  Files           6        6           
  Lines        1694     1695    +1     
=======================================
+ Hits         1504     1505    +1     
  Misses        190      190           
Impacted Files Coverage Δ
tests/test_ujson.py 99.54% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316d384...4ffc7dd. Read the comment docs.

@hugovk hugovk added the changelog: skip Exclude PR from release draft label Feb 6, 2022
@hugovk hugovk merged commit c41db2a into ultrajson:main Feb 6, 2022
@hugovk
Copy link
Member

hugovk commented Feb 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants