Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build step to deploy-wheels.yml that builds aarch64 wheels #422

Merged
merged 1 commit into from Sep 5, 2020
Merged

Add build step to deploy-wheels.yml that builds aarch64 wheels #422

merged 1 commit into from Sep 5, 2020

Conversation

geoffreyblake
Copy link
Contributor

@geoffreyblake geoffreyblake commented Sep 2, 2020

Creates a binary wheel for manylinux2014_aarch64 using docker buildx
and dumps the resulting artifacts into the dist/ folder for upload to pypi.

Fixes #421

Changes proposed in this pull request:

  • Adds buildx to the deploy-wheels.yml action, and creates the manylinux2014_aarch64 wheels in emulation
  • Add a Dockerfile_aarch64 to the scripts/ directory that creates the wheels and copies out the artifacts.

binary wheel for manylinux2014_aarch64 using docker buildx
and dumps the resulting artifacts into the dist/ folder.
@hugovk hugovk added changelog: Added For new features enhancement New feature or request release Deploy and release labels Sep 3, 2020
@hugovk hugovk merged commit e891005 into ultrajson:master Sep 5, 2020
@hugovk
Copy link
Member

hugovk commented Sep 5, 2020

Thanks!

The wheels built:

And deployed to TestPyPI:

Please could you test a deployed wheel (or wheels) install properly?

@geoffreyblake
Copy link
Contributor Author

@hugovk , the wheels that were posted to https://test.pypi.org/project/ujson/3.1.1.dev2/#files install and load fine on AArch64. I tested on a Graviton2 machine running Centos8. When can a new release of ujson be expected?

geoffreyblake added a commit to geoffreyblake/arm64-python-wheel-tester that referenced this pull request Sep 8, 2020
@hugovk
Copy link
Member

hugovk commented Sep 8, 2020

Thank you for testing!

I've just released UltraJSON 3.2.0 which has the new aarch64 wheels:

(btw I made a little adjustment to this PR so it builds Linux wheels in parallel: #423)

@geoffreyblake
Copy link
Contributor Author

Thanks for the quick review/release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features enhancement New feature or request release Deploy and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheels for manylinux2014_aarch64
2 participants